This is an archive of the discontinued LLVM Phabricator instance.

Differential D64847

Only build lldb-tblgen if it's not a current target
ClosedPublic

Authored by lanza on Jul 16 2019, 9:40 PM.

Details

Reviewers
xiaobai
Commits
rGbd3e74c73d96: Only build lldb-tblgen if it's not a current target
rLLDB366394: Only build lldb-tblgen if it's not a current target
rL366394: Only build lldb-tblgen if it's not a current target
Summary

When doing standalone builds, you could potentially be building against
an llvm which also built lldb. If this were the case, you'd be
attempting to build this target twice.

Diff Detail

Event Timeline

lanza created this revision.Jul 16 2019, 9:40 PM
Herald added a subscriber: mgorny. · View Herald TranscriptJul 16 2019, 9:40 PM
Harbormaster completed remote builds in B35134: Diff 210236.Jul 16 2019, 9:42 PM
lanza updated this revision to Diff 210238.Jul 16 2019, 9:51 PM

fix

Harbormaster completed remote builds in B35136: Diff 210238.Jul 16 2019, 9:52 PM
xiaobai accepted this revision.Jul 17 2019, 11:03 AM

This is a pretty interesting use case to say the least. I don't see an issue with it though, so go for it.

This revision is now accepted and ready to land.Jul 17 2019, 11:03 AM
lanza updated this revision to Diff 210475.Jul 17 2019, 6:26 PM

rebase

lanza closed this revision.Jul 17 2019, 6:27 PM
Harbormaster completed remote builds in B35218: Diff 210475.Jul 17 2019, 6:27 PM

Revision Contents

PathSize
utils/
TableGen/
20 lines

Diff 210238

utils/TableGen/CMakeLists.txt

# tablegen targets get exported via llvm for LLVMConfig.cmake. So standalone
# builds of lldb can potentially import this via LLVMConfig and also attempt to
# build it in tree. So only build it if it doesn't exist.
if (TARGET lldb-tblgen)
set(LLDB_TABLEGEN_EXE $<TARGET_FILE:lldb-tblgen> CACHE STRING "")
else()
set(LLVM_LINK_COMPONENTS Support) set(LLVM_LINK_COMPONENTS Support)
add_tablegen(lldb-tblgen LLDB add_tablegen(lldb-tblgen LLDB
LLDBOptionDefEmitter.cpp LLDBOptionDefEmitter.cpp
LLDBTableGen.cpp LLDBTableGen.cpp
) )
set_target_properties(lldb-tblgen PROPERTIES FOLDER "LLDB tablegenning") set_target_properties(lldb-tblgen PROPERTIES FOLDER "LLDB tablegenning")
endif()