Page MenuHomePhabricator

[BPF] add unit tests for preserve_{array,union,struct}_access_index intrinsics
ClosedPublic

Authored by yonghong-song on Jul 11 2019, 4:55 PM.

Details

Summary

This is a followup patch for https://reviews.llvm.org/D61810/new/,
which adds new intrinsics preserve_{array,union,struct}_access_index.

Currently, only BPF backend utilizes preserve_{array,union,struct}_access_index
intrinsics, so all tests are compiled with BPF target.

https://reviews.llvm.org/D61524 already added some tests for these
intrinsics, but some of them pretty complex.
This patch added a few unit test cases focusing on individual intrinsic
functions.

Also made a few clarification on language reference for these intrinsics.

Diff Detail

Repository
rL LLVM

Event Timeline

yonghong-song created this revision.Jul 11 2019, 4:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2019, 4:55 PM
Herald added a subscriber: arphaman. · View Herald Transcript
jdoerfert resigned from this revision.Jul 11 2019, 5:01 PM

Thank you for adding test and clarification as requested. Given that I am not working in this area, I will not do the actual review.

@jdoerfert Thanks for commenting on my diff. Will find the appropriate person to review.

ast accepted this revision.Jul 14 2019, 8:00 PM
This revision is now accepted and ready to land.Jul 14 2019, 8:00 PM
This revision was automatically updated to reflect the committed changes.