This is an archive of the discontinued LLVM Phabricator instance.

Differential D64588

Minor cleanup.
ClosedPublic

Authored by tra on Jul 11 2019, 1:32 PM.

Details

Reviewers
timshen
Summary

Simplify things a bit by removing unnecessary full type qualification.
This also happens to avoid a build break with now-unsupported Visual Studio 2015.

Diff Detail

Event Timeline

tra created this revision.Jul 11 2019, 1:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2019, 1:32 PM
Herald added subscribers: bixia, jlebar. · View Herald Transcript
Harbormaster completed remote builds in B34804: Diff 209315.Jul 11 2019, 1:32 PM
tra edited the summary of this revision. (Show Details)Jul 11 2019, 2:20 PM
timshen accepted this revision.Jul 11 2019, 2:22 PM
This revision is now accepted and ready to land.Jul 11 2019, 2:22 PM
tra closed this revision.Jul 18 2019, 9:37 AM

Landed ir r365913

Revision Contents

PathSize
llvm/
include/
llvm/
Analysis/
3 lines
Support/
3 lines

Diff 209315

llvm/include/llvm/Analysis/IteratedDominanceFrontier.h

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Implementation. // Implementation.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
namespace IDFCalculatorDetail { namespace IDFCalculatorDetail {
template <bool IsPostDom> template <bool IsPostDom>
typename ChildrenGetterTy<BasicBlock, IsPostDom>::ChildrenTy typename ChildrenGetterTy<BasicBlock, IsPostDom>::ChildrenTy
ChildrenGetterTy<BasicBlock, IsPostDom>::get( ChildrenGetterTy<BasicBlock, IsPostDom>::get(const NodeRef &N) {
const ChildrenGetterTy<BasicBlock, IsPostDom>::NodeRef &N) {
using OrderedNodeTy = using OrderedNodeTy =
typename IDFCalculatorBase<BasicBlock, IsPostDom>::OrderedNodeTy; typename IDFCalculatorBase<BasicBlock, IsPostDom>::OrderedNodeTy;
if (!GD) { if (!GD) {
auto Children = children<OrderedNodeTy>(N); auto Children = children<OrderedNodeTy>(N);
return {Children.begin(), Children.end()}; return {Children.begin(), Children.end()};
} }
Show All 15 Lines

llvm/include/llvm/Support/GenericIteratedDominanceFrontier.h

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Lines
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Implementation. // Implementation.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
namespace IDFCalculatorDetail { namespace IDFCalculatorDetail {
template <class NodeTy, bool IsPostDom> template <class NodeTy, bool IsPostDom>
typename ChildrenGetterTy<NodeTy, IsPostDom>::ChildrenTy typename ChildrenGetterTy<NodeTy, IsPostDom>::ChildrenTy
ChildrenGetterTy<NodeTy, IsPostDom>::get( ChildrenGetterTy<NodeTy, IsPostDom>::get(const NodeRef &N) {
const ChildrenGetterTy<NodeTy, IsPostDom>::NodeRef &N) {
using OrderedNodeTy = using OrderedNodeTy =
typename IDFCalculatorBase<NodeTy, IsPostDom>::OrderedNodeTy; typename IDFCalculatorBase<NodeTy, IsPostDom>::OrderedNodeTy;
auto Children = children<OrderedNodeTy>(N); auto Children = children<OrderedNodeTy>(N);
return {Children.begin(), Children.end()}; return {Children.begin(), Children.end()};
} }
} // end of namespace IDFCalculatorDetail } // end of namespace IDFCalculatorDetail
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines