Page MenuHomePhabricator

Use clang driver for libfuzzer tests on Windows
ClosedPublic

Authored by rnk on Jul 11 2019, 1:30 PM.

Details

Summary

There's no real reason to use clang-cl on Windows, the clang driver
works just as well. This fixes a test which uses the -O0 flag, which was
recently removed from clang-cl to match MSVC, which lacks this flag.

While I'm here, remove the explicit -std=c++11 flag. Previously, this
flag was necessary when the default C++ standard was C++98. Now that the
default is C++14, this is no longer necessary. It's problematic on
Windows, because the Visual C++ standard library relies on C++14
features, and attempting to compile it with C++11 results in errors.
Rather than adding logic to conditionally set the standard to C++11 only
on non-Win, this flag can be removed.

See http://lab.llvm.org:8011/builders/clang-x64-windows-msvc and
https://reviews.llvm.org/D64506.

Diff Detail

Repository
rL LLVM

Event Timeline

rnk created this revision.Jul 11 2019, 1:30 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 11 2019, 1:30 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
This revision is now accepted and ready to land.Jul 11 2019, 1:48 PM
This revision was automatically updated to reflect the committed changes.