Updated the signature for some stack related intrinsics (CLANG)
ClosedPublic
Actions

Authored by cdevadas on Jul 11 2019, 6:03 AM.

Details

Reviewers

Commits

rC366683: Updated the signature for some stack related intrinsics (CLANG)
rL366683: Updated the signature for some stack related intrinsics (CLANG)
rG8c5e6fa6575a: Updated the signature for some stack related intrinsics (CLANG)

Summary

This patch includes the intrinsics
int_addressofreturnaddress,
int_frameaddress & int_sponentry.
This patch should go along with the
changes in https://reviews.llvm.org/D64561

Diff Detail

Repository: rL LLVM

Event Timeline

cdevadas created this revision.Jul 11 2019, 6:03 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2019, 6:03 AM

Herald added subscribers: cfe-commits, wdng. · View Herald Transcript

Added alloca address space.

Can you add AMDGPU tests for these showing the correct address space is used

updated test/CodeGenOpenCL/builtins-generic-amdgcn.cl to vaildate the address space.

Herald added a subscriber: jvesely. · View Herald TranscriptJul 18 2019, 12:17 PM

LGTM

This revision is now accepted and ready to land.Jul 18 2019, 1:39 PM

Closed by commit rL366683: Updated the signature for some stack related intrinsics (CLANG) (authored by cdevadas, committed by ). · Explain WhyMon, Jul 22, 5:50 AM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptMon, Jul 22, 5:50 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents
Changeset List

			Path	Packages
M			cfe/trunk/lib/CodeGen/CGBuiltin.cpp (24 lines)
M			cfe/trunk/lib/CodeGen/CGException.cpp (3 lines)
M			cfe/trunk/test/CodeGen/builtin-sponentry.c (2 lines)
M			cfe/trunk/test/CodeGen/exceptions-seh.c (4 lines)
M			cfe/trunk/test/CodeGen/integer-overflow.c (8 lines)
M			cfe/trunk/test/CodeGen/ms-intrinsics.c (2 lines)
M			cfe/trunk/test/CodeGen/ms-setjmp.c (8 lines)
M			cfe/trunk/test/CodeGenOpenCL/builtins-generic-amdgcn.cl (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	209191			Jul 11 2019, 5:58 AM	★	★
Diff 2	209467			Jul 12 2019, 5:43 AM	★	★
Diff 3	210648			Jul 18 2019, 12:14 PM	★	★
Diff 4	211064	366682	rL366683	Mon, Jul 22, 5:50 AM	★	★