I saw while debugging that we call this file ParseInternal, which is not a very good name for our
fake expression file and also adds this unnecessary link between the way we name this function
and the other source location names we get from the expression parser. This patch is renaming
it to <lldb-expr> which is closer to the way Clang names its buffers, it doesn't depend on the
function name (which changes when I refactor this code) and it's easier to grep for.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
This seems fairly straighforward and I'm in favor of it. We maybe should do the same thing with swift, I haven't checked in a while how we call the file there.
I wouldn't bother adding a test for something so minor.