Page MenuHomePhabricator

LiveIntervals: Fix handleMove asserting on BUNDLE
ClosedPublic

Authored by arsenm on Jul 10 2019, 9:01 AM.

Details

Reviewers
qcolombet
MatzeB
Summary

The top-level BUNDLE instruction should behave as an ordinary
instruction. It is supposed to have all relevant registers as implicit
operands. Moving it should work as any other instruction. I believe
the assert intended to avoid moving instructions inside bundles.

Diff Detail

Event Timeline

arsenm created this revision.Jul 10 2019, 9:01 AM
qcolombet accepted this revision.Jul 19 2019, 12:05 PM
qcolombet added inline comments.
lib/CodeGen/LiveIntervals.cpp
1442

Maybe add a comment saying that it is totally fine to move a bundle as a whole to better explain what the assert checks.

This revision is now accepted and ready to land.Jul 19 2019, 12:05 PM
arsenm closed this revision.Jul 19 2019, 12:31 PM
arsenm marked an inline comment as done.

r366605