This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Quick Fix: IRExecutionUnit check pointer before access it
ClosedPublic

Authored by kusmour on Jul 9 2019, 11:47 AM.

Reviewers

xiaobai
compnerd

Commits

Summary

Move checking pointer code block before accessing the pointer
This caused lldb to crash when testing on Android

This revision is now accepted and ready to land.Jul 9 2019, 12:52 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

source/

Expression/

6 lines

Context not available.

	m_execution_engine_up.reset(builder.create(target_machine));	m_execution_engine_up.reset(builder.create(target_machine));

	m_strip_underscore =
	(m_execution_engine_up->getDataLayout().getGlobalPrefix() == '_');

	if (!m_execution_engine_up) {	if (!m_execution_engine_up) {
	error.SetErrorToGenericError();	error.SetErrorToGenericError();
	error.SetErrorStringWithFormat("Couldn't JIT the function: %s",	error.SetErrorStringWithFormat("Couldn't JIT the function: %s",
Context not available.
	return;	return;
	}	}

		m_strip_underscore =
		(m_execution_engine_up->getDataLayout().getGlobalPrefix() == '_');

	class ObjectDumper : public llvm::ObjectCache {	class ObjectDumper : public llvm::ObjectCache {
	public:	public:
	void notifyObjectCompiled(const llvm::Module *module,	void notifyObjectCompiled(const llvm::Module *module,
Context not available.