Page MenuHomePhabricator

Update libc++ include path detection to use VFS on Linux
ClosedPublic

Authored by juliehockett on Jul 8 2019, 5:14 PM.

Details

Summary

The DetectLibcxxIncludePath function had been using llvm::sys::fs::directory_iterator, and this updates it to use llvm::vfs::directory_iterator.

Diff Detail

Repository
rL LLVM

Event Timeline

juliehockett created this revision.Jul 8 2019, 5:14 PM
phosek accepted this revision.Jul 8 2019, 5:24 PM

LGTM

clang/lib/Driver/ToolChains/Linux.cpp
868 ↗(On Diff #208546)

Nit: can you make vfs the first argument?

This revision is now accepted and ready to land.Jul 8 2019, 5:24 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2019, 11:41 AM