Details
Details
Diff Detail
Diff Detail
Event Timeline
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp | ||
---|---|---|
4973–4992 | Just a side note: |
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp | ||
---|---|---|
4973–4992 | I think it is intentional not to use default here, otherwise people may forget to update this part when a new nvptx arch is added. I could let gfx archs go to the path with llvm_unreachable("Unexpected Cuda arch.") though. |
Just a side note:
I wonder if we need these at all -- we'll end up failing with misleading "Unexpected NVPTX target without ptx feature" assertion. We may just remove all non-SM_xx arch cases and replace them with default: calling llvm_unreachable(). Perhaps in a separate patch.