[zorg] Use https for svn-test-suite stage of buildbot

[kamaub]

Summary

svn checkout fails at the svn-test-suite stage of the buildbot bcse of a bug with svn when using http. This was originally identified in this [[ https://bugs.llvm.org/show_bug.cgi?id=36358 | bugzilla ]]report and fixed in this patch - rL329138. A module called LLVMBuildFactory was modified in this patch - rL346382 to handle the svn-test-suite stage but did not account for the need for secure http when running svn-test-suite. The code that did account for this need was replaced with code using the LLVMBuildFactory in this patch - rL346831.

In this patch edits in patch - rL346382 will be changed to also account for this bugzilla

[stefanp]

@gkistanova
Hi Galina,
We are having intermittent svn failures on our lnt build bot as a result of this http vs. https issue. (The bot: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt)
Would it be possible to take a look at this patch because we think that this will fix our bot.
Thank you!

[gkistanova]

Hello Kamau,

This is not a good idea to push every bot to have HTTPS overhead just because you have infrastructure problems with your 4 builders.

Instead, please specify vcs_protocol property for your bots to be https. This would make your bots check the source code out over HTTPS.

[kamaub]

Instead, please specify vcs_protocol property for your bots to be https. This would make your bots check the source code over HTTPS.

Hi Galina,
I'm not sure what this means, could you clarify. Are you referring to making a separate variable besides the master_protocol in zorg/buildbot/util/artifacts.py or overriding the master in a config file somewhere? I'm not sure what vcs_protocol is but i do agree with you, i shouldn't be forcing all that overhead onto all of the buildbots, thank you.

[gkistanova]

I mean something like this:

Index: zorg/buildbot/osuosl/master/config/slaves.py
===================================================================
--- zorg/buildbot/osuosl/master/config/slaves.py      (revision 365726)
+++ zorg/buildbot/osuosl/master/config/slaves.py      (working copy)
@@ -81,7 +81,7 @@

         # POWER7 PowerPC big endian (powerpc64)
         create_slave("ppc64be-clang-test", properties={'jobs': 16}, max_builds=1),
-        create_slave("ppc64be-clang-lnt-test", properties={'jobs': 16}, max_builds=1),
+        create_slave("ppc64be-clang-lnt-test", properties={'jobs': 16, 'vcs_protocol': 'https'}, max_builds=1),
         create_slave("ppc64be-clang-multistage-test", properties={'jobs': 16}, max_builds=1),
         create_slave("ppc64be-sanitizer", properties={'jobs': 16}, max_builds=1),

[kamaub]

So I made the change as recommend, thank you very much for all your help.

As far as I can tell rL365596 (thank you again :) )did all the leg work to make this change work. Is there anything else I would need to add?

[gkistanova]

That should be the only change for your builder.
Please feel free to commit.

[kamaub]

Hi @gkistanova I don't have commit permissions for zorg, would you be able to commit it for me?

[gkistanova]

Sure. I'll commit this for you.

zorg/trunk/buildbot/osuosl/master/config/slaves.py

return [
         # Windows 7 Intel(R) Xeon(R) CPU E5-2680 (2.80GHz), 16GB of RAM
         create_slave("windows7-buildbot", properties={'jobs': 2}, max_builds=1),
 
         # Windows Server 2016 Intel Xeon(R) Quad 2.30 GHz, 56GB of RAM
         create_slave("win-py3-buildbot", properties={'jobs' : 64}, max_builds=1),
 
         # POWER7 PowerPC big endian (powerpc64)
         create_slave("ppc64be-clang-test", properties={'jobs': 16}, max_builds=1),
-        create_slave("ppc64be-clang-lnt-test", properties={'jobs': 16}, max_builds=1),
+        create_slave("ppc64be-clang-lnt-test", properties={'jobs': 16, 'vcs_protocol': 'https'}, max_builds=1),
         create_slave("ppc64be-clang-multistage-test", properties={'jobs': 16}, max_builds=1),
         create_slave("ppc64be-sanitizer", properties={'jobs': 16}, max_builds=1),
 
         # POWER 8 PowerPC little endian (powerpc64le)
         create_slave("ppc64le-clang-test", properties={'jobs': 4}, max_builds=1),
         create_slave("ppc64le-clang-lnt-test", properties={'jobs': 8}, max_builds=1),
         create_slave("ppc64le-clang-multistage-test", properties={'jobs': 8}, max_builds=1),
         create_slave("ppc64le-sanitizer", properties={'jobs': 4}, max_builds=1),