Some out of tree backend require larger vector type. Since maintaining the changes out of tree is difficult due to the many manual changes needed when adding a new type we are adding it even if no backend currently use it.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Most of this looks mechanical; I don't think the MVT changes should be contentious. However, the "is65536BitVector()" predicates are starting to get a bit unwieldy to read.
Does an out of tree target need these predicates? I feel they're sufficiently unreadable to either change the format ("is64kBitVector"?) or elide them for larger types.
Cheers,
James
llvm/lib/CodeGen/ValueTypes.cpp | ||
---|---|---|
111 ↗ | (On Diff #207824) | [Formatting] Space missing here. |
Comment Actions
I agree, it is not really needed I added it for consistency. I don't mind changing it to the format suggested. Which ones do you think should be changed?
Comment Actions
LGTM
It doesn't look like is2048BitVector() is used, maybe we just don't add any new predicates until a use-case comes up?