Page MenuHomePhabricator

Add plugin.process.gdb-remote.use-libraries-svr4 option
ClosedPublic

Authored by aadsm on Jul 2 2019, 4:24 PM.

Details

Summary

This option allow the toggling of the libraries-svr4 usage in ProcessGDBRemote. It's a follow up of https://reviews.llvm.org/D62503#1564296 and it's meant to test / tweak this new packet with, hopefully, minimum impact and in a faster way.

Enable it with settings set plugin.process.gdb-remote.use-libraries-svr4 true. For now, by default it's false.

I didn't put tests up for this but I did test it manually.

Diff Detail

Repository
rL LLVM

Event Timeline

aadsm created this revision.Jul 2 2019, 4:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2019, 4:24 PM
labath accepted this revision.Jul 3 2019, 6:19 AM

Thank you.

I don't think tests are necessary right now, since this is effectively NFC for any in-tree server stub. Once we flip the value of the setting to true, it would be nice to add a test or two which loads some libraries with this setting explicitly set to false (emulating a no-libxml build). You can probably just adapt some tests in TestLoadUnload.py for that purpose.

This revision is now accepted and ready to land.Jul 3 2019, 6:19 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2019, 10:32 AM