This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] exploded-graph-rewriter: Collapse large statement pretty-prints.
ClosedPublic

Authored by NoQ on Jul 2 2019, 2:27 PM.

Details

Summary

When printing various statements that include braces (compound statements, lambda expressions, statement-expressions, etc.), replace the code between braces with '...'.

I don't mind losing some information here because it's easily recoverable by looking at the source code.

Before:

After:

Diff Detail

Repository
rL LLVM

Event Timeline

NoQ created this revision.Jul 2 2019, 2:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2019, 2:27 PM
Charusso accepted this revision.Jul 2 2019, 2:51 PM

I like it! What about BlockEdge with the long terminators? (c.f. Edge.getSrc()->printTerminatorJson())

This revision is now accepted and ready to land.Jul 2 2019, 2:51 PM
NoQ added a comment.Jul 2 2019, 2:56 PM

I like it! What about BlockEdge with the long terminators? (c.f. Edge.getSrc()->printTerminatorJson())

We don't process these yet >.< But it should be trivial to cover them in a similar manner once we implement them.

In D64104#1567326, @NoQ wrote:

I like it! What about BlockEdge with the long terminators? (c.f. Edge.getSrc()->printTerminatorJson())

We don't process these yet >.< But it should be trivial to cover them in a similar manner once we implement them.

Yes, great patch, thanks!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2019, 6:27 PM