This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] exploded-graph-rewriter: Improve program point dumps.
ClosedPublic

Authored by NoQ on Jul 1 2019, 5:47 PM.

Details

Summary
  • Take advantage of the stmt_point_kind.
  • Dump block IDs for BlockEntrance nodes.
  • Don't dump huge compound statements on PurgeDeadSymbols nodes.
  • Rename Edge to BlockEdge for consistency.
  • Tweak colors.

Before:


After:

Diff Detail

Repository
rL LLVM

Event Timeline

NoQ created this revision.Jul 1 2019, 5:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2019, 5:47 PM
NoQ edited the summary of this revision. (Show Details)Jul 1 2019, 5:49 PM
NoQ added a comment.Jul 1 2019, 5:53 PM

Ugly compound statement dumps that have been prevented:

Charusso accepted this revision.Jul 1 2019, 5:59 PM

Are you alright with the namings? Those are randomly came out from my head and may you know some better one.

I like the idea about color tones, it is great we have a huge palette, just I still feels like it pretty well made for a dark theme.
Are you sure about the white background?

In D64051#1565801, @NoQ wrote:

Ugly compound statement dumps that have been prevented:

Yea, they are crazy. Thanks for that patch!

This revision is now accepted and ready to land.Jul 1 2019, 5:59 PM
NoQ added a comment.Jul 1 2019, 6:49 PM

I like the idea about color tones, it is great we have a huge palette, just I still feels like it pretty well made for a dark theme.
Are you sure about the white background?

Okay. D64056

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 1 2019, 7:18 PM