Ordinarily it is lowered as a build_vector of each extract_vector_elt,
which in turn get lowered to bitcasts and bit shifts. Very little
understand the lowered extract pattern, resulting in much worse
code. We treat concat_vectors of v2i16 as legal, so prefer that.
Details
Details
- Reviewers
rampitec
Diff Detail
Diff Detail
Event Timeline
Comment Actions
LGTM with small suggestion.
lib/Target/AMDGPU/SIISelLowering.cpp | ||
---|---|---|
4750 | It's better to swap conditions. That way you will not read beyond the array even if accidentally pass an odd index. |
It's better to swap conditions. That way you will not read beyond the array even if accidentally pass an odd index.