Page MenuHomePhabricator

[UpdateTestChecks][NFC] Remove entries with same prefix
ClosedPublic

Authored by jsji on Jun 24 2019, 11:14 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

jsji created this revision.Jun 24 2019, 11:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2019, 11:14 AM
lebedev.ri added inline comments.
llvm/utils/UpdateTestChecks/asm.py
293 ↗(On Diff #206268)

Is x86 a real triple?
I've never seen it used.

jsji marked 2 inline comments as done.Jun 24 2019, 12:44 PM
jsji added inline comments.
llvm/utils/UpdateTestChecks/asm.py
293 ↗(On Diff #206268)

Good question.
enum Triple::x86 is a valid enum, but it actually maps to "i386", "i486", "i586", "i686", "i786", "i886", "i986" in triple strings.

However, in this script, we will return x86 in get_triple_from_march for unsupported -march when there is not triple specified in IR or command line.

So x86 is a valid entry here.

294 ↗(On Diff #206268)

Since x86 is not a real triple, we are actually missing support for i486, i586,...

There is only one i586 triple case found in current LLVM test.
llvm/test/CodeGen/X86/constructor.ll
So this is not a big issue.

lebedev.ri accepted this revision.Jun 26 2019, 3:55 AM
lebedev.ri added a reviewer: craig.topper.

Okay, thanks.

This revision is now accepted and ready to land.Jun 26 2019, 3:55 AM
This revision was automatically updated to reflect the committed changes.