Page MenuHomePhabricator

[UpdateTestChecks] [PowerPC] Add powerpc- triple support
ClosedPublic

Authored by jsji on Jun 24 2019, 9:24 AM.

Details

Summary

There are quite some old testcases with powerpc- triple,
we should add this triple support so that we can update them with script.

Appears identical to powerpc64{,le}, ppc32.
Regenerate one test that is being affected by upcoming patch.

Haven't seen assembly generated for AIX 32 (powerpc-ibm-aix-xcoff),
but we should be able to use the same one as well,
or else, we can fix it later when AIX 32 asm support lands.

Diff Detail

Repository
rL LLVM

Event Timeline

jsji created this revision.Jun 24 2019, 9:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2019, 9:24 AM
lebedev.ri added inline comments.Jun 24 2019, 9:35 AM
llvm/utils/UpdateTestChecks/asm.py
312–313 ↗(On Diff #206237)

These are identical to that new 'powerpc' entry, and given that the matching is 'lossy', they can be dropped.

jsji updated this revision to Diff 206261.Jun 24 2019, 10:47 AM
jsji marked an inline comment as done.
jsji added inline comments.
llvm/utils/UpdateTestChecks/asm.py
312–313 ↗(On Diff #206237)

Good point! Updated to remove powerpc64 and powerpc64le.

lebedev.ri accepted this revision.Jun 24 2019, 10:50 AM

Looks good.

This revision is now accepted and ready to land.Jun 24 2019, 10:50 AM
This revision was automatically updated to reflect the committed changes.