[analyzer] exploded-graph-rewriter: NFC: Extract some code into functions.

[NoQ]

Summary

Even though this code is not duplicated yet, follow-up patches will demonstrate that it's a nicer way to structure this code.

[Charusso]

I like that abstraction!

clang/utils/analyzer/exploded-graph-rewriter.py

def visit_environment(self, e, prev_e=None):
         else:
             for f in e.frames:
                 dump_location_context(f.location_context)
                 for b in f.bindings:
                     dump_binding(f, b)
 
         self._dump('</table>')
 
+    def visit_environment_in_state(self, s, prev_s=None):
+        self._dump('<tr><td align="left">'
+                   '<b>Environment: </b>')
+        if s.environment is None:
+            self._dump('<i> Nothing!</i>')
+        else:
+            if prev_s is not None and prev_s.environment is not None:
+                if s.environment.is_different(prev_s.environment):
+                    self._dump('</td></tr><tr><td align="left">')
+                    self.visit_environment(s.environment, prev_s.environment)
+                else:
+                    self._dump('<i> No changes!</i>')
+            else:
+                self._dump('</td></tr><tr><td align="left">')
+                self.visit_environment(s.environment)
+
+        self._dump('</td></tr>')
+
     def visit_store(self, s, prev_s=None):
         self._dump('<table border="0">')
 
         def dump_binding(s, c, b, is_added=None):
             self._dump('<tr><td>%s</td>'
                        '<td align="left">%s</td>'
                        '<td align="left">%s</td>'
                        '<td align="left">%s</td>'
def visit_store(self, s, prev_s=None):
                     dump_binding(s, c, b, True)
         else:
             for c in s.clusters:
                 for b in s.clusters[c].bindings:
                     dump_binding(s, c, b)
 
         self._dump('</table>')
 
-    def visit_state(self, s, prev_s):
-        # == Store ==
+    def visit_store_in_state(self, s, prev_s=None):
         self._dump('<tr><td align="left"><b>Store: </b>')
         if s.store is None:
             self._dump('<i> Nothing!</i>')
         else:
             if prev_s is not None and prev_s.store is not None:
                 if s.store.is_different(prev_s.store):
                     self._dump('</td></tr><tr><td align="left">')
                     self.visit_store(s.store, prev_s.store)
                 else:
                     self._dump('<i> No changes!</i>')
             else:
                 self._dump('</td></tr><tr><td align="left">')
                 self.visit_store(s.store)
         self._dump('</td></tr><hr />')
 
-        # == Environment ==
-        self._dump('<tr><td align="left">'
-                   '<b>Environment: </b>')
-        if s.environment is None:
-            self._dump('<i> Nothing!</i>')
-        else:
-            if prev_s is not None and prev_s.environment is not None:
-                if s.environment.is_different(prev_s.environment):
-                    self._dump('</td></tr><tr><td align="left">')
-                    self.visit_environment(s.environment, prev_s.environment)
-                else:
-                    self._dump('<i> No changes!</i>')
-            else:
-                self._dump('</td></tr><tr><td align="left">')
-                self.visit_environment(s.environment)
-
-        self._dump('</td></tr>')
+    def visit_state(self, s, prev_s):
+        self.visit_store_in_state(s, prev_s)
+        self.visit_environment_in_state(s, prev_s)
 
     def visit_node(self, node):
         self._dump('%s [shape=record,label=<<table border="0">'
                    % (node.node_name()))
 
         self._dump('<tr><td bgcolor="grey"><b>Node %d (%s) - '
                    'State %s</b></td></tr>'
                    % (node.node_id, node.ptr, node.state.state_id