Page MenuHomePhabricator

[llvm-readobj/llvm-readelf] - Eliminate the elf-groups.x86_64 precompiled binary from the inputs.

Authored by grimar on Jun 21 2019, 6:18 AM.



We do not need the elf-groups.x86_64. In one of the tests, it was
used for no solid reason, and for the second test case we can use
YAML input with SHT_GROUP sections.

The patch performs a cleanup of one of the test cases, removes another
one completely (since during the review was found out it actually
duplicates one of the existent tests) and removes the precompiled binary.

Diff Detail


Event Timeline

grimar created this revision.Jun 21 2019, 6:18 AM
jhenderson added inline comments.Jun 21 2019, 6:39 AM
2 ↗(On Diff #205982)

Remove "the".

47 ↗(On Diff #205982)

I'm not sure the OSABI is relevant?

1 ↗(On Diff #205982)

I think this test can just be deleted entirely actually. We have string-dump.test and string-dump-multi.test now.

grimar updated this revision to Diff 205996.Jun 21 2019, 7:19 AM
grimar marked 5 inline comments as done.
grimar edited the summary of this revision. (Show Details)
  • Addressed review comments.
47 ↗(On Diff #205982)

No. Removed.

1 ↗(On Diff #205982)

Removed, string-dump.test looks good.

This revision is now accepted and ready to land.Jun 21 2019, 8:03 AM
alexshap accepted this revision.Jun 21 2019, 3:42 PM

LG, thanks!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2019, 1:31 AM