So something I realized when trying to port clang interface stubs to using ASTNameGenerator instead of CodegenNameGenerator is that the original pimpl pattern used between CodegenNameGenerator and CodegenNameGeneratorImpl did a good job of hiding DataLayout making it so that users of CodegenNameGenerator did not need to link with llvm core. This is an NFC change to wrap ASTNameGenerator in a pimpl.
|343 ↗||(On Diff #205729)|
The implementation is never leaked to the user. This means that this is effectively private.
|416 ↗||(On Diff #205729)|
Don't think that it really matters to make this private or public really. The implementation is fully private.
|473 ↗||(On Diff #205729)|
llvm::make_unique would be nicer.