[Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder

[domada]

Summary

Scope of changes:

1. Moved addRecordedAssumptions to ScopBuilder class.
2. Moved Assumption struct outside Scop class.
3. Refactored addRecordedAssumptions function. Replaced while loop by for_range loop.
4. Added function to clear processed Assumptions.

[domada]

1. Remove unused function.

[Meinersbur]

[suggestion] RecordedAssumptions itself is only used during SCoP constructions (since it's empty once the SCoP is full constructed). It could be removed entirely into ScopBuilder, maybe in a future patch?

polly/lib/Analysis/ScopBuilder.cpp

391

Please remove commented-out code entirely.

[domada]

1. Removed commented code
2. Renamed iterator range to RecordedAssumptions to recorded_assumptions

[domada]

Ok, I will move entirely RecordedAssumptions to ScopBuilder in a future patch.

[Meinersbur]

LGTM

polly/include/polly/ScopInfo.h

2344

[suggestion] Add const qualifier

2345

Why reverse iterator? The user could also use llvm::reverse

[domada]

polly/include/polly/ScopInfo.h

2345

I was not aware of llvm::reverse function.

I needed reverse iterator for refactored addRecordedAssumptions function. I will fix this issue. Should I update review request or can I fix it when I will commit?

[Meinersbur]

polly/include/polly/ScopInfo.h

2345

I do sometimes the diff with a "Update before commit (+ changes)" message; Phabricator 'complains' with a "Changed prior to commit:" line if it thinks the commit and the patch are not identical (but it's not reliable).

I'd say, update the review if you are unsure about how you resolved the pending comments, but it is not required.

[domada]

Applied @Meinersbur remarks.

[Meinersbur]

LGTM