Page MenuHomePhabricator

[SROA] Enhance SROA to handle `addrspacecast`ed allocas
ClosedPublic

Authored by hliao on Jun 18 2019, 10:11 AM.

Details

Summary
  • After addrspacecast is allowed to be eliminated in SROA, the adjusting of storage pointer (from `alloca) needs to handle the potential different address spaces between the storage pointer (from alloca) and the pointer being used.

Diff Detail

Repository
rL LLVM

Event Timeline

hliao created this revision.Jun 18 2019, 10:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2019, 10:11 AM
arsenm requested changes to this revision.Jun 18 2019, 10:18 AM

This test case already works on trunk?

This revision now requires changes to proceed.Jun 18 2019, 10:18 AM
arsenm accepted this revision.Jun 18 2019, 10:20 AM

Nevermind, there's an assert with a debug build. LGTM

This revision is now accepted and ready to land.Jun 18 2019, 10:20 AM
This revision was automatically updated to reflect the committed changes.