Page MenuHomePhabricator

Propagate fmf in IRTranslate for fneg
ClosedPublic

Authored by mcberg2017 on Jun 17 2019, 1:51 PM.

Details

Summary

This case is related to D63405 in that we need to be propagating FMF on negates.

Diff Detail

Repository
rL LLVM

Event Timeline

mcberg2017 created this revision.Jun 17 2019, 1:51 PM
arsenm added inline comments.Jun 17 2019, 2:22 PM
test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll
1547 ↗(On Diff #205172)

Missing test with fneg instruction

mcberg2017 edited the summary of this revision. (Show Details)

There was an existing test, here it is with the modification for FMF

arsenm added inline comments.Jun 17 2019, 3:36 PM
test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll
832–834 ↗(On Diff #205193)

There should be one both with and without flags

1535 ↗(On Diff #205193)

Ditto

With cloned tests for FMF.

arsenm accepted this revision.Jun 17 2019, 4:06 PM

LGTM

This revision is now accepted and ready to land.Jun 17 2019, 4:06 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2019, 4:17 PM