Page MenuHomePhabricator

[Reproducers] Include lldb version in the reproducer root

Authored by JDevlieghere on Jun 12 2019, 2:28 PM.



Generally, reproducers are rev-locked to the version of LLDB, so it's valuable to have the LLDB version in the reproducer. For now I just want the information to be present, without enforcing it, but I envision emitting a warning during replay in the future.

Diff Detail


Event Timeline

JDevlieghere created this revision.Jun 12 2019, 2:28 PM
aprantl added inline comments.Jun 12 2019, 2:42 PM
114 ↗(On Diff #204356)

Isn't a struct with two static members basically a namespace? I'm curious, I have not seen this pattern before.

119 ↗(On Diff #204356)

Doxygen comments?

JDevlieghere marked 3 inline comments as done.

Adrian's feedback

Rebased to use the nested Info struct instead of the typedef.

aprantl accepted this revision.Jun 12 2019, 3:27 PM
This revision is now accepted and ready to land.Jun 12 2019, 3:27 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2019, 9:32 PM