Page MenuHomePhabricator

[Reproducers] Include lldb version in the reproducer root
ClosedPublic

Authored by JDevlieghere on Wed, Jun 12, 2:28 PM.

Details

Summary

Generally, reproducers are rev-locked to the version of LLDB, so it's valuable to have the LLDB version in the reproducer. For now I just want the information to be present, without enforcing it, but I envision emitting a warning during replay in the future.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Wed, Jun 12, 2:28 PM
aprantl added inline comments.Wed, Jun 12, 2:42 PM
lldb/include/lldb/Utility/Reproducer.h
114 ↗(On Diff #204356)

Isn't a struct with two static members basically a namespace? I'm curious, I have not seen this pattern before.

119 ↗(On Diff #204356)

Doxygen comments?

JDevlieghere marked 3 inline comments as done.

Adrian's feedback

Rebased to use the nested Info struct instead of the typedef.

aprantl accepted this revision.Wed, Jun 12, 3:27 PM
This revision is now accepted and ready to land.Wed, Jun 12, 3:27 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptWed, Jun 12, 9:32 PM