Page MenuHomePhabricator

X86: Clean up pass initialization
ClosedPublic

Authored by tstellar on Wed, Jun 12, 9:34 AM.

Details

Summary
  • Remove redundant initializations from pass constructors that were already being initialized by LLVMInitializeX86Target().
  • Move initialization of EdgeBundlesPass into LLVMInitializeX86Target.

Diff Detail

Repository
rL LLVM

Event Timeline

tstellar created this revision.Wed, Jun 12, 9:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Jun 12, 9:34 AM
Herald added a subscriber: hiraditya. · View Herald Transcript

Is the initializeEdgeBundlesPass because X86FloatingPoint.cpp doesn't have its own initialize function that could call INTIALIZE_PASS_DEPENDENCY?

Is the initializeEdgeBundlesPass because X86FloatingPoint.cpp doesn't have its own initialize function that could call INTIALIZE_PASS_DEPENDENCY?

Yes, that's what it looks like. Do you want me to update the patch to give X86FloatingPoint.cpp its own initialize function?

Is the initializeEdgeBundlesPass because X86FloatingPoint.cpp doesn't have its own initialize function that could call INTIALIZE_PASS_DEPENDENCY?

Yes, that's what it looks like. Do you want me to update the patch to give X86FloatingPoint.cpp its own initialize function?

That would probably be better. I think the initialize function is needed to make print-before-all/print-after-all see the pass so its good to have.

tstellar updated this revision to Diff 204325.Wed, Jun 12, 10:31 AM

Add initialization function for the FPS pass.

This revision is now accepted and ready to land.Wed, Jun 12, 11:06 AM
This revision was automatically updated to reflect the committed changes.