Page MenuHomePhabricator

gn build: Simplify Target build files
ClosedPublic

Authored by thakis on Jun 12 2019, 7:03 AM.

Details

Summary

Now that the cycle between MCTargetDesc and TargetInfo is gone
(see revisions 360709 360718 360722 360724 360726 360731 360733 360735 360736),
remove the dependency from TargetInfo on MCTargetDesc:tablegen. In most
targets, this makes MCTargetDesc:tablegen have just a single use, so
inline it there.

For AArch64, ARM, and RISCV there's still a similar cycle between
MCTargetDesc and Utils, so the MCTargetDesc:tablegen indirection is
still needed there.

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Jun 12 2019, 7:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2019, 7:03 AM

phosek: Ping :)

phosek: Ping :|

phosek accepted this revision.Jun 14 2019, 10:41 AM

LGTM

This revision is now accepted and ready to land.Jun 14 2019, 10:41 AM
Closed by commit rL363436: gn build: Simplify Target build files (authored by nico, committed by ). · Explain WhyJun 14 2019, 10:55 AM
This revision was automatically updated to reflect the committed changes.