Page MenuHomePhabricator

[Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder
ClosedPublic

Authored by domada on Jun 11 2019, 3:43 PM.

Details

Summary

Moved addInvariantLoads and functions listed below to ScopBuilder:
isAParameter
canAlwaysBeHoisted

These functions were referenced only by getNonHoistableCtx.

Moved CLI parameter PollyAllowDereferenceOfAllFunctionParams to
ScopBuilder.

Added iterator range through InvariantEquivClasses

Diff Detail

Repository
rL LLVM

Event Timeline

domada created this revision.Jun 11 2019, 3:43 PM
Herald added a project: Restricted Project. · View Herald Transcript
Meinersbur accepted this revision.Jun 11 2019, 9:08 PM

LGTM apart from the nitpicks.

I can commit for you when you think it's ready.

polly/include/polly/ScopInfo.h
2335 ↗(On Diff #204183)

[typo] interator

[nit] An iterator range does not contain any elements.

I usually don't nitpick on this: Sentence missing a dot at the end.

2336 ↗(On Diff #204183)

nice

polly/lib/Analysis/ScopBuilder.cpp
1469 ↗(On Diff #204183)

[suggestion] Make a static function?

This revision is now accepted and ready to land.Jun 11 2019, 9:08 PM
domada marked 2 inline comments as done.Jun 12 2019, 1:26 PM

Updated new patch with applied remarks.

domada updated this revision to Diff 204350.Jun 12 2019, 1:28 PM

Applied remarks.

If there are no more remarks, I think the patch is ready for submission.

This revision was automatically updated to reflect the committed changes.