This is an archive of the discontinued LLVM Phabricator instance.

[ThinLTO][Bitcode] Add 'entrycount' to FS_COMBINED_PROFILE. NFC
ClosedPublic

Authored by evgeny777 on Jun 10 2019, 8:21 AM.

Details

Summary

This field has been missing from abbreviation for a while, however things still work because abbreviation has array field at the end. I don't see how this can be tested unless llvm-bcanalyzer is taught to dump abbreviations.

Diff Detail

Event Timeline

evgeny777 created this revision.Jun 10 2019, 8:21 AM
tejohnson accepted this revision.Jun 12 2019, 12:06 PM

Interesting - does this mean we just encoded it with a VBR 4 (what numrefs was to be encoded with), and everything else just got shifted down in the encoding (so immutablerefcnt got encoded as the first VBR 8 in the array at the end)? Unfortunate that there isn't a way to test for this.

lgtm

This revision is now accepted and ready to land.Jun 12 2019, 12:06 PM

Interesting - does this mean we just encoded it with a VBR 4 (what numrefs was to be encoded with)

Exactly.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2019, 5:31 AM