Page MenuHomePhabricator

Implements multiline regex support
Needs RevisionPublic

Authored by Mordante on Jun 9 2019, 7:29 AM.

Details

Reviewers
mclow.lists
Summary

It implements the multiline support as described at https://wg21.link/LWG2503

Diff Detail

Event Timeline

Mordante created this revision.Jun 9 2019, 7:29 AM
mclow.lists added a comment.EditedJun 26 2019, 8:50 AM

To keep the code easier to read, I would be tempted to remove almost all of the #ifdefs here, and just make __use_multiline and the constants depend on the language level.
[ Note that I haven't tried this; just looking to make the code simpler. ]

mclow.lists added inline comments.Jun 26 2019, 8:53 AM
libcxx/include/regex
2003

I think that this is going to have to go behind an "ABI break" flag, because it changes the size of __l_anchor. I'll look into it some more.

mclow.lists requested changes to this revision.Jun 26 2019, 12:12 PM

Note: Since this was resolved by an LWG issue (rather than a paper), we should provide this capability back to C++11.
(So you can get rid of all the #ifdefs

This revision now requires changes to proceed.Jun 26 2019, 12:12 PM

Thanks for the review.

Once it's known whether or not the __l_anchor changes are an ABI break I'll update the patch.
Is there a way to test what is and what is not an ABI break?