Page MenuHomePhabricator

[WebAssembly] Improve lto/comdat.ll test. NFC.
ClosedPublic

Authored by sbc100 on Jun 5 2019, 11:48 AM.

Details

Summary

We were not previously testing the comdat exclusion with bitcode
object parsing because we were linking two copied of the .bc file and
the linkonce_odr linkage type was removing the duplicate _start
function during LTO.

Now we link an bitcode and non-bitcode version both of which contains
a copy of _start. And we link them in both orders, which means this
test will fail if comdat exclusion is not working correctly in the
parsing of the bitcode file.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Jun 5 2019, 11:48 AM
sbc100 added a reviewer: ruiu.Jun 5 2019, 11:48 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2019, 2:09 PM
Closed by commit rL362650: [WebAssembly] Improve lto/comdat.ll test. NFC. (authored by sbc, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.