Page MenuHomePhabricator

UpdateTestChecks: hexagon support
ClosedPublic

Authored by lebedev.ri on Jun 4 2019, 10:22 AM.

Details

Summary

These tests are being affected by an upcoming patch,
so having an understandable (autogenerated) diff is helpful.

This target, again, prefers -march:

llvm/test/CodeGen/Hexagon$ grep -r triple | wc -l
467
llvm/test/CodeGen/Hexagon$ grep -r march | wc -l
1167

Diff Detail

Repository
rL LLVM

Event Timeline

lebedev.ri created this revision.Jun 4 2019, 10:22 AM
lebedev.ri retitled this revision from UpdateTestChecks: hexagon suppose to UpdateTestChecks: hexagon support.Jun 4 2019, 10:33 AM

What is this in preparation of? Why are only these 3 tests affected?

I guess I'm ok with this, but I'm hoping you're not planning to convert all Hexagon tests to use these autogenerated checks...

What is this in preparation of? Why are only these 3 tests affected?

Because only these 3 tests are affected in the patch i'm about to post.

And having the ability to autogenerate these check lines radically
simplifies the developer's ability to work with the diff, instead of
first having to write the code, and then write the check lines too.

I guess I'm ok with this, but

I'm hoping you're not planning to convert all Hexagon tests to use these autogenerated checks...

Correct, i'm most certainly NOT planning on doing that.

I recently hit this issue too and I had to manually update these files :/ so, thank you for this patch!

kparzysz accepted this revision.Jun 4 2019, 12:35 PM
This revision is now accepted and ready to land.Jun 4 2019, 12:35 PM
Closed by commit rL362605: UpdateTestChecks: hexagon support (authored by lebedevri, committed by ). · Explain WhyJun 5 2019, 7:07 AM
This revision was automatically updated to reflect the committed changes.