[llvm-readobj] - Remove TODOs from gnu-hash-symbols.test and demangle.test test cases

[grimar]

Summary

We can remove this TODOs now.

This depends (and rebased) on D62809.

[jhenderson]

LGTM, although I note that the symbols are no longer STT_FUNC. Is that intentional? Does it matter (probably not)?

[grimar]

In D62846#1528999, @jhenderson wrote:

LGTM, although I note that the symbols are no longer STT_FUNC. Is that intentional? Does it matter (probably not)?

I just tried to reduce the YAML description. The type does not seem to be important, so I removed it.

llvm/trunk/test/tools/llvm-readobj/demangle.test

 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_DYN
   Machine:         EM_X86_64
 Sections:
-  ## TODO:  Replace the raw section contents with more meaningful dynamic
-  ## tags/symbols/etc, once yaml2obj supports it.
-  ## FIXME: yaml2obj does not currently allow custom addresses for .dynstr and
-  ## .dynsym if DynamicSymbols are specified.
-  ## See https://bugs.llvm.org/show_bug.cgi?id=40339
   - Name:         .dynstr
     Type:         SHT_STRTAB
     Flags:        [ SHF_ALLOC ]
     AddressAlign: 0x100
     EntSize:      0x1
-    ## "\0_Z3fooi\0"
-    Content: "005f5a33666f6f6900"
   - Name:         .dynsym
     Type:         SHT_DYNSYM
     Flags:        [ SHF_ALLOC ]
     Link:         .dynstr
     Address:      0x100
     AddressAlign: 0x100
     EntSize:      0x18
-    ## Null symbol;
-    ## st_name: 1; st_info: Global | Func; st_other: 0;
-    ##   st_shndx: .text.foo; st_value: 0x2000; st_size: 0
-    Content: "000000000000000000000000000000000000000000000000010000001200050000200000000000000000000000000000"
   - Name:         .rela.dyn
     Type:         SHT_RELA
     Flags:        [ SHF_ALLOC ]
     Link:         .dynsym
     Info:         .text.foo
     Address:      0x200
     AddressAlign: 0x100
     EntSize:      0x18
Symbols:
   - Name:    _Z3fooc
     Type:    STT_FUNC
     Section: .text.foo
     Binding: STB_GLOBAL
   - Name:    _Z4blahf
     Type:    STT_FUNC
     Section: .text.foo
     Binding: STB_GLOBAL
+DynamicSymbols:
+  - Name:    _Z3fooi
+    Binding: STB_GLOBAL
 ProgramHeaders:
   - Type:  PT_LOAD
     Flags: [ PF_R, PF_X ]
     VAddr: 0x0
     PAddr: 0x0
     Sections:
       - Section: .dynsym
       - Section: .dynstr

llvm/trunk/test/tools/llvm-readobj/gnu-hash-symbols.test

 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_DYN
   Machine:         EM_X86_64
 Sections:
-  ## TODO:  Replace the raw section contents with more meaningful dynamic
-  ## tags/symbols/etc, once yaml2obj supports it.
-  ## FIXME: yaml2obj does not currently allow custom addresses for .dynstr and
-  ## .dynsym if DynamicSymbols are specified.
-  ## See https://bugs.llvm.org/show_bug.cgi?id=40339
   - Name:         .dynstr
     Type:         SHT_STRTAB
     Flags:        [ SHF_ALLOC ]
     AddressAlign: 0x100
     EntSize:      0x1
-    ## "\0_Z3fooi\0"
-    Content: "005f5a33666f6f6900"
   - Name:         .dynsym
     Type:         SHT_DYNSYM
     Flags:        [ SHF_ALLOC ]
     Link:         .dynstr
     Address:      0x100
     AddressAlign: 0x100
     EntSize:      0x18
-    ## Null symbol;
-    ## st_name: 1; st_info: Global | Func; st_other: 0;
-    ##   st_shndx: .text.foo; st_value: 0x2000; st_size: 0
-    Content: "000000000000000000000000000000000000000000000000010000001200040000200000000000000000000000000000"
   - Name:            .dynamic
     Type:            SHT_DYNAMIC
     Flags:           [ SHF_ALLOC ]
     Address:         0x0000000000001000
     Link:            .dynstr
     AddressAlign:    0x0000000000001000
     EntSize:         0x0000000000000010
     Entries:
       - Tag:             DT_STRTAB
         Value:           0x0000000000000000
       - Tag:             DT_STRSZ
         Value:           0x0000000000000009
       - Tag:             DT_SYMTAB
         Value:           0x0000000000000100
       - Tag:             DT_SYMENT
         Value:           0x0000000000000018
       - Tag:             DT_NULL
         Value:           0x0000000000000000
   - Name:  .text.foo
     Type:  SHT_PROGBITS
     Flags: [ SHF_ALLOC, SHF_EXECINSTR, SHF_GROUP ]
     Size:  0x40
     Address: 0x2000
     AddressAlign: 0x2000
+DynamicSymbols:
+  - Name:    _Z3fooi
+    Binding: STB_GLOBAL
 ProgramHeaders:
   - Type:  PT_LOAD
     Flags: [ PF_R, PF_X ]
     VAddr: 0x0
     PAddr: 0x0
     Sections:
       - Section: .dynsym
       - Section: .dynstr
       - Section: .dynamic
       - Section: .text.foo
   - Type:  PT_DYNAMIC
     Flags: [ PF_R ]
     VAddr: 0x1000
     PAddr: 0x1000
     Sections:
       - Section: .dynamic