This is an archive of the discontinued LLVM Phabricator instance.

[LLD][COFF] Don't take into account the 'age' when looking for PDB type server
ClosedPublic

Authored by aganea on Jun 3 2019, 7:39 PM.

Details

Summary

The age field is only there to say how many times an OBJ or a PDB was incrementally linked. It shouldn't be used to validate the link between the OBJ and the PDB.
I've ensured that linking a large project yields the same output as link.exe without /ignore:4099
This should fix the LNK4099 issues you're seeing on Chrome.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

aganea created this revision.Jun 3 2019, 7:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2019, 7:39 PM
aganea edited the summary of this revision. (Show Details)
aganea updated this revision to Diff 203045.Jun 4 2019, 4:37 PM

@thakis : Updated the existing test to fail without this patch.

rnk accepted this revision.Jun 4 2019, 4:54 PM

lgtm

Macro shipit:

Wait, did someone enable phab memes in the last update? This is too silly. =p

This revision is now accepted and ready to land.Jun 4 2019, 4:54 PM
thakis accepted this revision.Jun 4 2019, 5:03 PM
smeenai added a subscriber: smeenai.Jun 4 2019, 6:18 PM

Phabricator memes are the best thing about Phabricator :)

shipit has been around since Jun 14 2016 according to https://reviews.llvm.org/macro/, so I'm not sure why it would suddenly start appearing. Macros are only active if the name appears by itself on a line though, so perhaps you just never happened to do that before?

aganea added a comment.Jun 4 2019, 6:41 PM

Maybe Reid was talking about this icon, was it there before?

This revision was automatically updated to reflect the committed changes.
rnk added a comment.Jun 5 2019, 9:44 AM

Phabricator memes are the best thing about Phabricator :)

shipit has been around since Jun 14 2016 according to https://reviews.llvm.org/macro/, so I'm not sure why it would suddenly start appearing. Macros are only active if the name appears by itself on a line though, so perhaps you just never happened to do that before?

I though Phab had "serious mode" that we enabled to disable all the old "clowncopterize" flavor text. But, I guess that's all been gone since 2014:
https://secure.phabricator.com/D8812