This is an archive of the discontinued LLVM Phabricator instance.

[HWASAN][CMake] Allow instrumenting LLVM/clang
ClosedPublic

Authored by evgeny777 on Jun 3 2019, 8:49 AM.

Reviewers

kcc
eugenis

Commits

Summary

One can't simply pass -fsanitize=hwaddress to CFLAGS, because DSOs will fail to link due to -Wl,-z,defs being passed to linker

LGTM

This revision is now accepted and ready to land.Jun 3 2019, 1:07 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

cmake/

modules/

3 lines

	Show First 20 Lines • Show All 691 Lines • ▼ Show 20 Lines
	endmacro()			endmacro()

	# Turn on sanitizers if necessary.			# Turn on sanitizers if necessary.
	if(LLVM_USE_SANITIZER)			if(LLVM_USE_SANITIZER)
	if (LLVM_ON_UNIX)			if (LLVM_ON_UNIX)
	if (LLVM_USE_SANITIZER STREQUAL "Address")			if (LLVM_USE_SANITIZER STREQUAL "Address")
	append_common_sanitizer_flags()			append_common_sanitizer_flags()
	append("-fsanitize=address" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)			append("-fsanitize=address" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
				elseif (LLVM_USE_SANITIZER STREQUAL "HWAddress")
				append_common_sanitizer_flags()
				append("-fsanitize=hwaddress" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
	elseif (LLVM_USE_SANITIZER MATCHES "Memory(WithOrigins)?")			elseif (LLVM_USE_SANITIZER MATCHES "Memory(WithOrigins)?")
	append_common_sanitizer_flags()			append_common_sanitizer_flags()
	append("-fsanitize=memory" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)			append("-fsanitize=memory" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
	if(LLVM_USE_SANITIZER STREQUAL "MemoryWithOrigins")			if(LLVM_USE_SANITIZER STREQUAL "MemoryWithOrigins")
	append("-fsanitize-memory-track-origins" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)			append("-fsanitize-memory-track-origins" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
	endif()			endif()
	elseif (LLVM_USE_SANITIZER STREQUAL "Undefined")			elseif (LLVM_USE_SANITIZER STREQUAL "Undefined")
	append_common_sanitizer_flags()			append_common_sanitizer_flags()
	▲ Show 20 Lines • Show All 288 Lines • Show Last 20 Lines