This is an archive of the discontinued LLVM Phabricator instance.

Differential D62697

AMDGPU: Disable errno by default
ClosedPublic

Authored by arsenm on May 30 2019, 1:01 PM.

Download Raw Diff

Details

Reviewers

yaxunl

Diff Detail

Event Timeline

arsenm created this revision.May 30 2019, 1:01 PM

Herald added subscribers: t-tye, tpr, dstuttard and 4 others. · View Herald TranscriptMay 30 2019, 1:01 PM

ping

LGTM. Sorry for the delay.

This revision is now accepted and ready to land.Jun 17 2019, 7:13 AM

r363682

Revision Contents

Path

Size

lib/

Driver/

ToolChains/

AMDGPU.h

2 lines

test/

Driver/

fast-math.c

6 lines

Diff 202281

lib/Driver/ToolChains/AMDGPU.h

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines	const StringRef getOptionDefault(options::ID OptID) const {
return opt->second;		return opt->second;
}		}

public:		public:
AMDGPUToolChain(const Driver &D, const llvm::Triple &Triple,		AMDGPUToolChain(const Driver &D, const llvm::Triple &Triple,
const llvm::opt::ArgList &Args);		const llvm::opt::ArgList &Args);
unsigned GetDefaultDwarfVersion() const override { return 5; }		unsigned GetDefaultDwarfVersion() const override { return 5; }
bool IsIntegratedAssemblerDefault() const override { return true; }		bool IsIntegratedAssemblerDefault() const override { return true; }
		bool IsMathErrnoDefault() const override { return false; }

llvm::opt::DerivedArgList *		llvm::opt::DerivedArgList *
TranslateArgs(const llvm::opt::DerivedArgList &Args, StringRef BoundArch,		TranslateArgs(const llvm::opt::DerivedArgList &Args, StringRef BoundArch,
Action::OffloadKind DeviceOffloadKind) const override;		Action::OffloadKind DeviceOffloadKind) const override;

void addClangTargetOptions(const llvm::opt::ArgList &DriverArgs,		void addClangTargetOptions(const llvm::opt::ArgList &DriverArgs,
llvm::opt::ArgStringList &CC1Args,		llvm::opt::ArgStringList &CC1Args,
Action::OffloadKind DeviceOffloadKind) const override;		Action::OffloadKind DeviceOffloadKind) const override;
};		};

} // end namespace toolchains		} // end namespace toolchains
} // end namespace driver		} // end namespace driver
} // end namespace clang		} // end namespace clang

#endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_AMDGPU_H		#endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_AMDGPU_H

test/Driver/fast-math.c

	Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
	// RUN: %clang -### -target x86_64-unknown-openbsd -c %s 2>&1 \			// RUN: %clang -### -target x86_64-unknown-openbsd -c %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s			// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
	// RUN: %clang -### -target x86_64-unknown-dragonfly -c %s 2>&1 \			// RUN: %clang -### -target x86_64-unknown-dragonfly -c %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s			// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
	// RUN: %clang -### -target x86_64-fuchsia -c %s 2>&1 \			// RUN: %clang -### -target x86_64-fuchsia -c %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s			// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
	// RUN: %clang -### -target x86_64-linux-android -c %s 2>&1 \			// RUN: %clang -### -target x86_64-linux-android -c %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s			// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
				// RUN: %clang -### -target amdgcn-amd-amdhsa -c %s 2>&1 \
				// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
				// RUN: %clang -### -target amdgcn-amd-amdpal -c %s 2>&1 \
				// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
				// RUN: %clang -### -target amdgcn-mesa-mesa3d -c %s 2>&1 \
				// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
	//			//
	// Check that -ffast-math disables -fmath-errno, and -fno-fast-math merely			// Check that -ffast-math disables -fmath-errno, and -fno-fast-math merely
	// preserves the target default. Also check various flag set operations between			// preserves the target default. Also check various flag set operations between
	// the two flags. (Resuses above checks.)			// the two flags. (Resuses above checks.)
	// RUN: %clang -### -ffast-math -c %s 2>&1 \			// RUN: %clang -### -ffast-math -c %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s			// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
	// RUN: %clang -### -fmath-errno -ffast-math -c %s 2>&1 \			// RUN: %clang -### -fmath-errno -ffast-math -c %s 2>&1 \
	// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s			// RUN: \| FileCheck --check-prefix=CHECK-NO-MATH-ERRNO %s
	▲ Show 20 Lines • Show All 208 Lines • Show Last 20 Lines