This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj] - Convert gnu-sections.test to use YAML.
ClosedPublic

Authored by grimar on May 30 2019, 6:42 AM.

Details

Summary

gnu-sections.test currently use relocs.obj.elf-x86_64 and
relocs.obj.elf-i386 precompiled objects as an inputs.

These inputs actually initially were introduced to test the
dump of relocations and have almost nothing common with dumping
sections.

Patch converts the test to use yaml2obj. That allows to remove
relocs.obj.elf-i386 binary.
(relocs.obj.elf-x86_64 is still used by another test and can't be removed atm).

This patch is rebased on top of D62655.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.May 30 2019, 6:42 AM
MaskRay added inline comments.May 30 2019, 8:55 AM
test/tools/llvm-readobj/gnu-sections.test
59 ↗(On Diff #202179)

It seems this is the only test that uses --wide -W (ignored option in llvm-readobj). This probably needs a comment.

grimar updated this revision to Diff 202397.May 31 2019, 2:11 AM
  • Addressed review comment.
MaskRay accepted this revision.May 31 2019, 4:11 AM
This revision is now accepted and ready to land.May 31 2019, 4:11 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2019, 3:00 AM