Page MenuHomePhabricator

Support Universal dSYM files in llvm-objdump
ClosedPublic

Authored by mtrent on May 29 2019, 8:43 PM.

Details

Summary

Commonly programmers use llvm-objdump to disassemble Mach-O target
binaries with Mach-O dSYMS. While llvm-objdump allows programmers to
disassemble Universal binaries, it previously did not recognize
Universal dSYM files. This change updates llvm-objdump to support
passing in Universal files via the -dsym option. Now, when
disassembling a Mach-O file either as a stand alone file or as an entry
in a Universal binariy, llvm-objdump will search through a Universal
dSYM for a Mach-O matching the architecture flag of the file being
disassembled.

Diff Detail

Repository
rL LLVM

Event Timeline

mtrent created this revision.May 29 2019, 8:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2019, 8:43 PM
Herald added a subscriber: rupprecht. · View Herald Transcript
mtrent updated this revision to Diff 202200.May 30 2019, 8:12 AM

Increasing error checking to catch symbolic files that are neither
Mach-O nor Universal object files.

pete accepted this revision.May 30 2019, 9:50 AM

LGTM.

tools/llvm-objdump/MachODump.cpp
7294 ↗(On Diff #202200)

The formatting looks off here compared to the rest of the code.

This revision is now accepted and ready to land.May 30 2019, 9:50 AM
mtrent updated this revision to Diff 202240.May 30 2019, 10:51 AM

Remove tabs inserted by emacs (grr)

mtrent marked 2 inline comments as done.May 30 2019, 10:52 AM
mtrent added inline comments.
tools/llvm-objdump/MachODump.cpp
7294 ↗(On Diff #202200)

stupid emacs.

This revision was automatically updated to reflect the committed changes.
mtrent marked an inline comment as done.