Page MenuHomePhabricator

CallSiteSplitting: Respect convergent
ClosedPublic

Authored by arsenm on May 29 2019, 5:47 AM.

Diff Detail

Event Timeline

arsenm created this revision.May 29 2019, 5:47 AM
hfinkel accepted this revision.May 29 2019, 7:51 AM
hfinkel added a subscriber: hfinkel.

LGTM

This revision is now accepted and ready to land.May 29 2019, 7:51 AM
fhahn added a comment.May 29 2019, 8:54 AM

Thanks for fixing this! LGTM. As for the test name, it might be worth calling out it tests convergent and noduplicate or something like function-attrbibutes.ll. Maybe also mention no duplicate in the commit message.

arsenm closed this revision.May 29 2019, 9:56 AM

r361990

grokos added a subscriber: grokos.May 29 2019, 12:08 PM

Also, can you include a reference in the commit message pointing to D56274 as this was the case demonstrating the need for this fix? Thanks!