Page MenuHomePhabricator

Remove the redundant using LoopVectorizationPlanner:VPlanPtr
ClosedPublic

Authored by psamolysov on May 29 2019, 3:03 AM.

Details

Summary
VPlan.h already contains the declaration of VPlanPtr type alias:

using VPlanPtr = std::unique_ptr<VPlan>;

The LoopVectorizationPlanner class also contains the same declaration
of VPlanPtr and therefore LoopVectorize requires a long wording when
its methods return VPlanPtr:

LoopVectorizationPlanner::VPlanPtr
LoopVectorizationPlanner::buildVPlanWithVPRecipes(...)

but LoopVectorize.cpp includes VPlan.h (via LoopVectorizationPlanner.h)
and can use VPlanPtr from that header.

Diff Detail

Event Timeline

psamolysov created this revision.May 29 2019, 3:03 AM
fhahn accepted this revision.May 29 2019, 10:01 PM

LGTM, thanks! Let me know if you need someone to commit this patch

This revision is now accepted and ready to land.May 29 2019, 10:01 PM

@fhahn thanks, yes, I need.

This revision was automatically updated to reflect the committed changes.