Page MenuHomePhabricator

[cmake] Apply static archive touch logic from D62172 to libraries not using llvm_add_library.
AbandonedPublic

Authored by hintonda on May 24 2019, 4:18 PM.

Details

Reviewers
thakis
beanz
Summary

These libraries don't invoke llvm_add_library, so apply touch fix
from D62172 directly.

As noted in D62172, this is due to an old version of libtool on Mac
that doesn't support high-resolution timers, which the latest
version of ninja does. Therefore, static libs almost always end up
with an older timestamp than the last object added or updated,
forcing ninja to update the archive and everything that depends on
it.

Event Timeline

hintonda created this revision.May 24 2019, 4:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2019, 4:18 PM
Herald added a subscriber: mgorny. · View Herald Transcript
hintonda retitled this revision from [cmake] Apply static archive touching logic from D62172 to libraries not using llvm_add_library. to [cmake] Apply static archive touch logic from D62172 to libraries not using llvm_add_library..May 24 2019, 5:18 PM
hintonda edited the summary of this revision. (Show Details)
hintonda abandoned this revision.May 25 2019, 11:49 AM

There are several more of these, so I've come up with a better solution and will submit a patch to D62172 that moves this logic into llvm_update_compile_flags instead.