This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Add test for requires and unified shared memory clause with declare target link
ClosedPublic

Authored by gtbercea on May 24 2019, 9:54 AM.

Details

Summary

This patch adds a test for requires with unified share memory clause when a declare target link is present.

This test needs to go in prior to changes to declare target link for comparison purposes.

Diff Detail

Repository
rC Clang

Event Timeline

gtbercea created this revision.May 24 2019, 9:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2019, 9:54 AM

Just one question - why it is not the part of the whole patch for the unified memory support in clang?

Just one question - why it is not the part of the whole patch for the unified memory support in clang?

This test will need to change in the unified memory case. That's why its being introduced.

Just add it to the original patch

ABataev accepted this revision.May 24 2019, 11:16 AM

After some offline discussion, the patch is accepted. It is required to demonstrate the changes in
https://reviews.llvm.org/D60883

This revision is now accepted and ready to land.May 24 2019, 11:16 AM
This revision was automatically updated to reflect the committed changes.