Page MenuHomePhabricator

[Runtimes] If LLVM_INCLUDE_TESTS=On depend on gtest
ClosedPublic

Authored by beanz on May 22 2019, 1:43 PM.

Details

Summary

If we are building the tests for the runtimes we should make them depend on gtest so that gtest is built and ready before we run any of the check-* targets.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz created this revision.May 22 2019, 1:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 22 2019, 1:43 PM
Herald added a subscriber: mgorny. · View Herald Transcript
beanz added a comment.May 22 2019, 2:09 PM

Just came to my attention this explodes on some versions of CMake. I'm looking at it and will update once I find a better approach.

beanz updated this revision to Diff 200819.May 22 2019, 2:13 PM

Fixing this patch

compnerd accepted this revision.May 22 2019, 2:33 PM
This revision is now accepted and ready to land.May 22 2019, 2:33 PM
This revision was automatically updated to reflect the committed changes.