This is an archive of the discontinued LLVM Phabricator instance.

Remove extra if case.
ClosedPublic

Authored by akhuang on May 21 2019, 11:42 AM.

Download Raw Diff

Details

Reviewers

Commits

rZORGbf4eae5bb6e7: Combine two if cases because the second one is never reached.
rGbf4eae5bb6e7: Combine two if cases because the second one is never reached.
rG63305c8fbba7: Combine two if cases because the second one is never reached.
rC361400: Combine two if cases because the second one is never reached.
rL361400: Combine two if cases because the second one is never reached.

Diff Detail

Repository: rL LLVM

Event Timeline

akhuang created this revision.May 21 2019, 11:42 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2019, 11:42 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B32248: Diff 200558.May 21 2019, 11:46 AM

lgtm

Testing offline showed that it was impossible to reach the return with a real global variable with an enumeration type.

This revision is now accepted and ready to land.May 21 2019, 1:19 PM

Closed by commit rL361400: Combine two if cases because the second one is never reached. (authored by akhuang). · Explain WhyMay 22 2019, 8:46 AM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptMay 22 2019, 8:46 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

Path

Size

cfe/

trunk/

lib/

CodeGen/

CGDebugInfo.cpp

10 lines

Diff 200765

cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

Show First 20 Lines • Show All 4,346 Lines • ▼ Show 20 Lines	void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init) {
assert(DebugKind >= codegenoptions::LimitedDebugInfo);		assert(DebugKind >= codegenoptions::LimitedDebugInfo);
if (VD->hasAttr<NoDebugAttr>())		if (VD->hasAttr<NoDebugAttr>())
return;		return;
auto Align = getDeclAlignIfRequired(VD, CGM.getContext());		auto Align = getDeclAlignIfRequired(VD, CGM.getContext());
// Create the descriptor for the variable.		// Create the descriptor for the variable.
llvm::DIFile *Unit = getOrCreateFile(VD->getLocation());		llvm::DIFile *Unit = getOrCreateFile(VD->getLocation());
StringRef Name = VD->getName();		StringRef Name = VD->getName();
llvm::DIType *Ty = getOrCreateType(VD->getType(), Unit);		llvm::DIType *Ty = getOrCreateType(VD->getType(), Unit);

		// Do not use global variables for enums.
if (const auto *ECD = dyn_cast<EnumConstantDecl>(VD)) {		if (const auto *ECD = dyn_cast<EnumConstantDecl>(VD)) {
const auto *ED = cast<EnumDecl>(ECD->getDeclContext());		const auto *ED = cast<EnumDecl>(ECD->getDeclContext());
assert(isa<EnumType>(ED->getTypeForDecl()) && "Enum without EnumType?");		assert(isa<EnumType>(ED->getTypeForDecl()) && "Enum without EnumType?");
Ty = getOrCreateType(QualType(ED->getTypeForDecl(), 0), Unit);
}
// Do not use global variables for enums.
//
// FIXME: why not?
if (Ty->getTag() == llvm::dwarf::DW_TAG_enumeration_type)
return;		return;
		}

// Do not emit separate definitions for function local const/statics.		// Do not emit separate definitions for function local const/statics.
if (isa<FunctionDecl>(VD->getDeclContext()))		if (isa<FunctionDecl>(VD->getDeclContext()))
return;		return;
VD = cast<ValueDecl>(VD->getCanonicalDecl());		VD = cast<ValueDecl>(VD->getCanonicalDecl());
auto *VarD = cast<VarDecl>(VD);		auto *VarD = cast<VarDecl>(VD);
if (VarD->isStaticDataMember()) {		if (VarD->isStaticDataMember()) {
auto *RD = cast<RecordDecl>(VarD->getDeclContext());		auto *RD = cast<RecordDecl>(VarD->getDeclContext());
getDeclContextDescriptor(VarD);		getDeclContextDescriptor(VarD);
▲ Show 20 Lines • Show All 256 Lines • Show Last 20 Lines