This is an archive of the discontinued LLVM Phabricator instance.

Differential D62194

AMDGPU: Fix not marking new gfx10 SGPRs as CSRs
ClosedPublic

Authored by arsenm on May 21 2019, 6:51 AM.

Details

Reviewers
rampitec

Diff Detail

Event Timeline

arsenm created this revision.May 21 2019, 6:51 AM
Herald added subscribers: t-tye, tpr, dstuttard and 5 others. · View Herald TranscriptMay 21 2019, 6:51 AM
rampitec accepted this revision.May 21 2019, 10:46 AM

LGTM

This revision is now accepted and ready to land.May 21 2019, 10:46 AM
arsenm closed this revision.May 21 2019, 4:21 PM

r361330

Revision Contents

PathSize
lib/
Target/
AMDGPU/
6 lines
test/
CodeGen/
AMDGPU/
15 lines

Diff 200491

lib/Target/AMDGPU/AMDGPUCallingConv.td

Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Lines
def CSR_AMDGPU_VGPRs_24_255 : CalleeSavedRegs< def CSR_AMDGPU_VGPRs_24_255 : CalleeSavedRegs<
(sequence "VGPR%u", 24, 255) (sequence "VGPR%u", 24, 255)
>; >;
def CSR_AMDGPU_VGPRs_32_255 : CalleeSavedRegs< def CSR_AMDGPU_VGPRs_32_255 : CalleeSavedRegs<
(sequence "VGPR%u", 32, 255) (sequence "VGPR%u", 32, 255)
>; >;
def CSR_AMDGPU_SGPRs_32_103 : CalleeSavedRegs< def CSR_AMDGPU_SGPRs_32_105 : CalleeSavedRegs<
(sequence "SGPR%u", 32, 103) (sequence "SGPR%u", 32, 105)
>; >;
def CSR_AMDGPU_HighRegs : CalleeSavedRegs< def CSR_AMDGPU_HighRegs : CalleeSavedRegs<
(add CSR_AMDGPU_VGPRs_32_255, CSR_AMDGPU_SGPRs_32_103) (add CSR_AMDGPU_VGPRs_32_255, CSR_AMDGPU_SGPRs_32_105)
>; >;
// Calling convention for leaf functions // Calling convention for leaf functions
def CC_AMDGPU_Func : CallingConv<[ def CC_AMDGPU_Func : CallingConv<[
CCIfByVal<CCPassByVal<4, 4>>, CCIfByVal<CCPassByVal<4, 4>>,
CCIfType<[i1], CCPromoteToType<i32>>, CCIfType<[i1], CCPromoteToType<i32>>,
CCIfType<[i1, i8, i16], CCIfExtend<CCPromoteToType<i32>>>, CCIfType<[i1, i8, i16], CCIfExtend<CCPromoteToType<i32>>>,
CCIfType<[i32, f32, i16, f16, v2i16, v2f16, i1], CCAssignToReg<[ CCIfType<[i32, f32, i16, f16, v2i16, v2f16, i1], CCAssignToReg<[
Show All 36 Lines

test/CodeGen/AMDGPU/csr-gfx10.ll

  • This file was added.
; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1010 -o - %s | FileCheck -check-prefix=GFX10 %s
; Make sure new higher SGPRs are callee saved
; GFX10-LABEL: {{^}}callee_new_sgprs:
; GFX10: v_writelane_b32 v0, s104, 0
; GFX10: v_writelane_b32 v0, s105, 1
; GFX10: ; clobber s104
; GFX10: ; clobber s105
; GFX10: v_readlane_b32 s105, v0, 1
; GFX10: v_readlane_b32 s104, v0, 0
define void @callee_new_sgprs() {
call void asm sideeffect "; clobber s104", "~{s104}"()
call void asm sideeffect "; clobber s105", "~{s105}"()
ret void
}