Remove explicit header-filter in run_clang_tidy.py

[juliehockett]

Summary

This removes the else clause that adds a default -header-filter flag to clang-tidy invocations from the run_clang_tidy.py script. If this clause is present, any HeaderFilterRegex settings in the .clang-tidy file are ignored and would have to be explicitly passed to the script each time.

[hintonda]

Great idea.

Please see D61747.

[juliehockett]

@hintonda Aha so it is :)

[hintonda]

In D62157#1509289, @juliehockett wrote:

@hintonda Aha so it is :)

I don't think it's at all controversial, so I'll commit D61747 tomorrow unless someone raises an issue. Thanks...

clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

 
 def get_tidy_invocation(f, clang_tidy_binary, checks, tmpdir, build_path,
                         header_filter, extra_arg, extra_arg_before, quiet,
                         config):
   """Gets a command line for clang-tidy."""
   start = [clang_tidy_binary]
   if header_filter is not None:
     start.append('-header-filter=' + header_filter)
-  else:
-    # Show warnings in all in-project headers by default.
-    start.append('-header-filter=^' + build_path + '/.*')
   if checks:
     start.append('-checks=' + checks)
   if tmpdir is not None:
     start.append('-export-fixes')
     # Get a temporary file. We immediately close the handle so clang-tidy can
     # overwrite it.
     (handle, name) = tempfile.mkstemp(suffix='.yaml', dir=tmpdir)
     os.close(handle)