This is an archive of the discontinued LLVM Phabricator instance.

Differential D62041

[Docs] Remove SVN checkout from LLDB build steps
ClosedPublic

Authored by jryans on May 16 2019, 3:38 PM.

Download Raw Diff

Details

Reviewers

Commits

rZORG7a4ad8e9d280: [Docs] Remove SVN checkout from LLDB build steps
rG7a4ad8e9d280: [Docs] Remove SVN checkout from LLDB build steps
rG777cad2c448f: [Docs] Remove SVN checkout from LLDB build steps
rLLDB361046: [Docs] Remove SVN checkout from LLDB build steps
rL361046: [Docs] Remove SVN checkout from LLDB build steps

Summary

This removes several older paragraphs in the LLDB build steps for Unix systems
which suggested checking out various components via SVN. Since there's a
separate page about getting the LLDB source which only mentions Git, it seems
appropriate to remove this older info from the build docs.

Diff Detail

Repository

rG LLVM Github Monorepo

Build Status

Buildable 32015
Build 32014: arc lint + arc unit

Event Timeline

jryans created this revision.May 16 2019, 3:38 PM

Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2019, 3:38 PM

Harbormaster completed remote builds in B32015: Diff 199920.May 16 2019, 3:38 PM

JDevlieghere added inline comments.May 16 2019, 4:35 PM

lldb/docs/resources/build.rst
242	Let's remove the next paragraph as well and remove the whole section.

Updated to remove the whole section

Harbormaster completed remote builds in B32055: Diff 199993.May 17 2019, 1:55 AM

Thanks for the review @JDevlieghere! 😄 This should be ready for another look. I don't have commit access yet, so assuming it's approved, please commit when you have time.

lldb/docs/resources/build.rst
242	Makes sense to me! I have updated to do so.

jryans marked an inline comment as done.May 17 2019, 1:58 AM

LGTM. Thank you!

JDevlieghere accepted this revision.May 17 2019, 9:20 AM

This revision is now accepted and ready to land.May 17 2019, 9:20 AM

Closed by commit rL361046: [Docs] Remove SVN checkout from LLDB build steps (authored by JDevlieghere). · Explain WhyMay 17 2019, 9:22 AM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2019, 9:22 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

Path

Size

lldb/

docs/

resources/

build.rst

37 lines

Diff 199920

lldb/docs/resources/build.rst

	Show First 20 Lines • Show All 233 Lines • ▼ Show 20 Lines

	::			::

	> pkgin install swig python27 cmake ninja-build			> pkgin install swig python27 cmake ninja-build


	Building LLDB			Building LLDB

	We first need to checkout the source trees into the appropriate locations. Both
	Clang and LLDB build as subprojects of LLVM. This means we will be checking out
	the source for both Clang and LLDB into the tools subdirectory of LLVM. We will
	be setting up a directory hierarchy looking something like this:

	::

	llvm
	\|
	`-- tools
	\|
	+-- clang
	\|
	`-- lldb

	For reference, we will call the root of the LLVM project tree $llvm, and the
	roots of the Clang and LLDB source trees $clang and $lldb respectively.

	Change to the directory where you want to do development work and checkout
	LLVM:

	::

	> svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm


	Now switch to LLVM’s tools subdirectory and checkout both Clang and LLDB:

	::

	> cd $llvm/tools
	> svn co http://llvm.org/svn/llvm-project/cfe/trunk clang
	> svn co http://llvm.org/svn/llvm-project/lldb/trunk lldb

	In general, building the LLDB trunk revision requires trunk revisions of both
	LLVM and Clang.

	It is highly recommended that you build the system out of tree. Create a second			It is highly recommended that you build the system out of tree. Create a second
				JDevlieghereUnsubmitted Done Reply Inline Actions Let's remove the next paragraph as well and remove the whole section. JDevlieghere: Let's remove the next paragraph as well and remove the whole section.
				jryansAuthorUnsubmitted Done Reply Inline Actions Makes sense to me! I have updated to do so. jryans: Makes sense to me! I have updated to do so.
	build directory and configure the LLVM project tree to your specifications as			build directory and configure the LLVM project tree to your specifications as
	outlined in LLVM’s Getting Started Guide. A typical build procedure might be:			outlined in LLVM’s Getting Started Guide. A typical build procedure might be:

	::			::

	> cd $llvm/..			> cd $llvm/..
	> mkdir build			> mkdir build
	> cd build			> cd build
	▲ Show 20 Lines • Show All 246 Lines • Show Last 20 Lines