Page MenuHomePhabricator

[Docs] Remove SVN checkout from LLDB build steps
ClosedPublic

Authored by jryans on May 16 2019, 3:38 PM.

Details

Summary

This removes several older paragraphs in the LLDB build steps for Unix systems
which suggested checking out various components via SVN. Since there's a
separate page about getting the LLDB source which only mentions Git, it seems
appropriate to remove this older info from the build docs.

Diff Detail

Repository
rL LLVM

Event Timeline

jryans created this revision.May 16 2019, 3:38 PM
Herald added a project: Restricted Project. ยท View Herald TranscriptMay 16 2019, 3:38 PM
JDevlieghere added inline comments.May 16 2019, 4:35 PM
lldb/docs/resources/build.rst
242 โ†—(On Diff #199920)

Let's remove the next paragraph as well and remove the whole section.

jryans updated this revision to Diff 199993.May 17 2019, 1:54 AM

Updated to remove the whole section

jryans marked 2 inline comments as done.May 17 2019, 1:56 AM

Thanks for the review @JDevlieghere! ๐Ÿ˜„ This should be ready for another look. I don't have commit access yet, so assuming it's approved, please commit when you have time.

lldb/docs/resources/build.rst
242 โ†—(On Diff #199920)

Makes sense to me! I have updated to do so.

jryans marked an inline comment as done.May 17 2019, 1:58 AM

LGTM. Thank you!

JDevlieghere accepted this revision.May 17 2019, 9:20 AM
This revision is now accepted and ready to land.May 17 2019, 9:20 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. ยท View Herald TranscriptMay 17 2019, 9:22 AM
Herald added a subscriber: llvm-commits. ยท View Herald Transcript