This is an archive of the discontinued LLVM Phabricator instance.

build: use clang-cl for runtimes when targeting Windows
ClosedPublic

Authored by compnerd on May 16 2019, 2:06 PM.

Details

Reviewers
beanz
smeenai
Summary

Adjust the CMAKE_C{,XX}_COMPILER passed to the subproject build for the runtimes when targeting Windows.

Diff Detail

Repository
rL LLVM

Event Timeline

compnerd created this revision.May 16 2019, 2:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2019, 2:06 PM
Herald added a subscriber: mgorny. · View Herald Transcript
beanz accepted this revision.May 16 2019, 2:54 PM

LGTM.

This revision is now accepted and ready to land.May 16 2019, 2:54 PM
plotfi added a subscriber: plotfi.May 17 2019, 12:35 PM

Note: I think we should probably do something about the linker here too. so use lld-link instead of ld.lld in the Windows case.

compnerd updated this revision to Diff 200084.May 17 2019, 12:58 PM

update for linker as well and the non-primary builtins

beanz accepted this revision.May 17 2019, 1:00 PM

LGTM. Makes sense.

compnerd closed this revision.May 17 2019, 1:06 PM

SVN r361072