This is an archive of the discontinued LLVM Phabricator instance.

Differential D61945

ftime-trace as a CoreOption
ClosedPublic

Authored by aganea on May 15 2019, 7:03 AM.

Details

Reviewers
thakis
anton-afanasyev
Commits
rZORG2f4097330123: ftime-trace as a CoreOption
rG2f4097330123: ftime-trace as a CoreOption
rG738e42efb3c4: ftime-trace as a CoreOption
rC360907: ftime-trace as a CoreOption
rL360907: ftime-trace as a CoreOption
Summary

As suggested here by @thakis , make so that -ftime-trace can be used directly in clang-cl without -Xclang

Diff Detail

Repository
rL LLVM

Event Timeline

aganea created this revision.May 15 2019, 7:03 AM
anton-afanasyev accepted this revision.May 15 2019, 7:08 AM

LGTM, thanks!

This revision is now accepted and ready to land.May 15 2019, 7:08 AM
Closed by commit rL360907: ftime-trace as a CoreOption (authored by aganea). · Explain WhyMay 16 2019, 8:14 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2019, 8:14 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
cfe/
trunk/
include/
clang/
Driver/
2 lines
test/
Driver/
1 line

Diff 199836

cfe/trunk/include/clang/Driver/Options.td

Show First 20 Lines • Show All 1,741 Lines • ▼ Show 20 Lines
// Just silence warnings about -Wlarger-than for now. // Just silence warnings about -Wlarger-than for now.
def Wlarger_than_EQ : Joined<["-"], "Wlarger-than=">, Group<clang_ignored_f_Group>; def Wlarger_than_EQ : Joined<["-"], "Wlarger-than=">, Group<clang_ignored_f_Group>;
def Wlarger_than_ : Joined<["-"], "Wlarger-than-">, Alias<Wlarger_than_EQ>; def Wlarger_than_ : Joined<["-"], "Wlarger-than-">, Alias<Wlarger_than_EQ>;
def Wframe_larger_than_EQ : Joined<["-"], "Wframe-larger-than=">, Group<f_Group>, Flags<[DriverOption]>; def Wframe_larger_than_EQ : Joined<["-"], "Wframe-larger-than=">, Group<f_Group>, Flags<[DriverOption]>;
def : Flag<["-"], "fterminated-vtables">, Alias<fapple_kext>; def : Flag<["-"], "fterminated-vtables">, Alias<fapple_kext>;
def fthreadsafe_statics : Flag<["-"], "fthreadsafe-statics">, Group<f_Group>; def fthreadsafe_statics : Flag<["-"], "fthreadsafe-statics">, Group<f_Group>;
def ftime_report : Flag<["-"], "ftime-report">, Group<f_Group>, Flags<[CC1Option]>; def ftime_report : Flag<["-"], "ftime-report">, Group<f_Group>, Flags<[CC1Option]>;
def ftime_trace : Flag<["-"], "ftime-trace">, Group<f_Group>, Flags<[CC1Option]>; def ftime_trace : Flag<["-"], "ftime-trace">, Group<f_Group>, Flags<[CC1Option, CoreOption]>;
def ftlsmodel_EQ : Joined<["-"], "ftls-model=">, Group<f_Group>, Flags<[CC1Option]>; def ftlsmodel_EQ : Joined<["-"], "ftls-model=">, Group<f_Group>, Flags<[CC1Option]>;
def ftrapv : Flag<["-"], "ftrapv">, Group<f_Group>, Flags<[CC1Option]>, def ftrapv : Flag<["-"], "ftrapv">, Group<f_Group>, Flags<[CC1Option]>,
HelpText<"Trap on integer overflow">; HelpText<"Trap on integer overflow">;
def ftrapv_handler_EQ : Joined<["-"], "ftrapv-handler=">, Group<f_Group>, def ftrapv_handler_EQ : Joined<["-"], "ftrapv-handler=">, Group<f_Group>,
MetaVarName<"<function name>">, MetaVarName<"<function name>">,
HelpText<"Specify the function to be called on overflow">; HelpText<"Specify the function to be called on overflow">;
def ftrapv_handler : Separate<["-"], "ftrapv-handler">, Group<f_Group>, Flags<[CC1Option]>; def ftrapv_handler : Separate<["-"], "ftrapv-handler">, Group<f_Group>, Flags<[CC1Option]>;
def ftrap_function_EQ : Joined<["-"], "ftrap-function=">, Group<f_Group>, Flags<[CC1Option]>, def ftrap_function_EQ : Joined<["-"], "ftrap-function=">, Group<f_Group>, Flags<[CC1Option]>,
▲ Show 20 Lines • Show All 1,430 Lines • Show Last 20 Lines

cfe/trunk/test/Driver/cl-options.c

Show First 20 Lines • Show All 632 Lines • ▼ Show 20 Lines
// RUN: -fbracket-depth=123 \ // RUN: -fbracket-depth=123 \
// RUN: -fprofile-generate \ // RUN: -fprofile-generate \
// RUN: -fprofile-generate=dir \ // RUN: -fprofile-generate=dir \
// RUN: -fno-profile-generate \ // RUN: -fno-profile-generate \
// RUN: -fno-profile-instr-generate \ // RUN: -fno-profile-instr-generate \
// RUN: -fno-profile-instr-use \ // RUN: -fno-profile-instr-use \
// RUN: -fcs-profile-generate \ // RUN: -fcs-profile-generate \
// RUN: -fcs-profile-generate=dir \ // RUN: -fcs-profile-generate=dir \
// RUN: -ftime-trace \
// RUN: --version \ // RUN: --version \
// RUN: -Werror /Zs -- %s 2>&1 // RUN: -Werror /Zs -- %s 2>&1
// Accept clang options under the /clang: flag. // Accept clang options under the /clang: flag.
// The first test case ensures that the SLP vectorizer is on by default and that // The first test case ensures that the SLP vectorizer is on by default and that
// it's being turned off by the /clang:-fno-slp-vectorize flag. // it's being turned off by the /clang:-fno-slp-vectorize flag.
// RUN: %clang_cl -O2 -### -- %s 2>&1 | FileCheck -check-prefix=NOCLANG %s // RUN: %clang_cl -O2 -### -- %s 2>&1 | FileCheck -check-prefix=NOCLANG %s
Show All 11 Lines